Closed
Conversation
Owner
|
Thanks! You even order the highlight groups consistently! :D One minor thing, but important IMHO: Can you add some examples of the new commands to the test files, |
- \DeclareMathOperator - \operatorname - \numberwithin - \subjclass
- \theoremstyle
- \newtheorem
- \begin{proof}
- theorem-like environments
Contributor
Author
|
I added examples with tests for all 5 commands in the PR and for \begin{proof}. Rebased to master after the commit implementing #2086, everything seems to be working great together. Thanks! |
lervag
added a commit
that referenced
this pull request
Aug 27, 2021
Owner
|
Thanks! Great work, much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\DeclareMathOperator: since the body is in math mode, do not spell check\theoremstyle,\numberwithin(2 args),\subjclas(1 opt + 1 arg): do not spell-check.